X Tutup
Skip to content

simplified, added comment on usetex#6107

Closed
dacoex wants to merge 4 commits intomatplotlib:masterfrom
dacoex:pdfmulti_tex
Closed

simplified, added comment on usetex#6107
dacoex wants to merge 4 commits intomatplotlib:masterfrom
dacoex:pdfmulti_tex

Conversation

@dacoex
Copy link
Copy Markdown
Contributor

@dacoex dacoex commented Mar 4, 2016

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 4, 2016

I am slightly biased towards leaving the example as usetex=True and the comment saying 'if you do not have LaTeX installed change this to False'.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Mar 4, 2016
@dacoex
Copy link
Copy Markdown
Contributor Author

dacoex commented Mar 4, 2016

@tacaswell I can change although I cannot see what would require the use of text in that segment.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 4, 2016

Showing off that it can be done. Integration with LaTeX is a major selling point in some fields and it defaults to False to avoid these sorts of issues.

QuLogic
QuLogic reviewed Mar 4, 2016
View reviewed changes
examples/pylab_examples/multipage_pdf.py Outdated

plt.rc('text', usetex=True)
plt.rc('text', usetex=True) # if LaTeX is not installed or error caught,
# change to `usetex=False` to make it work
Copy link
Copy Markdown
Member

@QuLogic QuLogic Mar 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not aligned any more; however, I think it might be simpler to just place the comment above the code (if it fits within 80 characters).

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Mar 4, 2016

Can you please rebase and squash the commits together?

It appears that the first commit does not have your correct email address; please be sure that it is correct after rebasing.

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Mar 6, 2016

When you rebase you need to do a force-push to gh

git push --force dacoex pdfmulti_tex

@dacoex dacoex closed this Mar 7, 2016
@dacoex dacoex deleted the pdfmulti_tex branch March 7, 2016 00:03
@dacoex dacoex mentioned this pull request Mar 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Documentation status: duplicate

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@dacoex @tacaswell @QuLogic @mdboom
X Tutup