X Tutup
Skip to content

TST: fix tiny test differences#6020

Merged
QuLogic merged 1 commit intomatplotlib:v2.xfrom
tacaswell:fix_colorbar_tests
Feb 18, 2016
Merged

TST: fix tiny test differences#6020
QuLogic merged 1 commit intomatplotlib:v2.xfrom
tacaswell:fix_colorbar_tests

Conversation

@tacaswell
Copy link
Copy Markdown
Member

No description provided.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Feb 18, 2016

I didn't check all, but it looks like the blue value is one less on the second red in the colourmap. It's not a big deal so 👍 if CI is fine.

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Feb 18, 2016
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Feb 18, 2016

Looks like you missed one though: matplotlib.tests.test_colorbar.test_colorbar_closed_patch.test

@tacaswell
Copy link
Copy Markdown
Member Author

Sorry about that. I did this on my laptop which might not have inkscape installed. It is indeed a 1 bit color flip

 L 158.4 32.4 
 L 158.4 43.2 
-" style="fill:#6bacd1;"/>
-    <path clip-path="url(#p2f8cb6be76)" d="M 288 43.2 
+" style="fill:#6bacd0;"/>
+    <path clip-path="url(#p3d4ec13d54)" d="M 288 43.2 
 L 417.6 43.2 
 L 417.6 32.4 
 L 288 32.4 
 L 288 43.2 
-" style="fill:#6bacd1;"/>
-    <path clip-path="url(#p2f8cb6be76)" d="M 417.6 43.2 
+" style="fill:#6bacd0;"/>
+    <path clip-path="url(#p3d4ec13d54)" d="M 417.6 43.2 
 L 547.2 43.2 
 L 547.2 32.4 
 L 417.6 32.4 
 L 417.6 43.2 
-" style="fill:#6bacd1;"/>
-    <path clip-path="url(#p2f8cb6be76)" d="M 28.8 32.4 
+" style="fill:#6bacd0;"/>
+    <path clip-path="url(#p3d4ec13d54)" d="M 28.8 32.4 

@tacaswell tacaswell closed this Feb 18, 2016
@tacaswell tacaswell reopened this Feb 18, 2016
QuLogic added a commit that referenced this pull request Feb 18, 2016
@QuLogic QuLogic merged commit 9e0a46a into matplotlib:v2.x Feb 18, 2016
@tacaswell tacaswell deleted the fix_colorbar_tests branch February 18, 2016 20:03
@tacaswell
Copy link
Copy Markdown
Member Author

Merged v2.x up to master so all of the tests should be un-broken now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup