Merged
Conversation
This would be an API break, however at some point most of these attributes were removed from the module so trying to bulk import would raise an AttributeError.
The comment says that this is used by IPython (circa 2008) however it's use was removed from the IPython code base in 770734dc47d57cdebc365fcbcd313e76a22be89d Author: Brian Granger <ellisonbg@gmail.com> 2009-07-21 15:28:37 which Precedes: rel-0.11 so no supported version of IPython still has this code.
Now that the backend resolution is done in `pylab_setup` instead of at module import time this does not need to be imported after the call to _backend_selection.
- add backend as an input (maybe useful?) - add numpydoc style docstring
| from matplotlib.rcsetup import interactive_bk | ||
|
|
||
| __all__ = ['backend','show','draw_if_interactive', | ||
| 'new_figure_manager', 'backend_version'] |
Member
Author
There was a problem hiding this comment.
Most of these things are no longer exist in the module so it would raise an AttributeError.
Member
Author
|
I left pretty through commit messages on all of these changes. |
Member
|
Ah, indeed. Ok, this looks fine to me. I take it none of this is supposed to be backported? |
This was referenced Mar 2, 2016
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.