mathtext: Fix comma behaviour at start of string#5882
Merged
mdboom merged 2 commits intomatplotlib:masterfrom Jan 25, 2016
Merged
mathtext: Fix comma behaviour at start of string#5882mdboom merged 2 commits intomatplotlib:masterfrom
mdboom merged 2 commits intomatplotlib:masterfrom
Conversation
Member
Author
|
ping @mdboom |
mdboom
added a commit
that referenced
this pull request
Jan 25, 2016
mathtext: Fix comma behaviour at start of string
mdboom
modified the milestones:
next bug fix release (2.0.1),
Critical bug fix release (1.5.2)
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Oct 16, 2016
mathtext: Fix comma behaviour at start of string
Member
|
Backported to v2.x via b04c5b9. |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the comma between braces in #5813 introduced a bug when a comma is at the beginning of the string: e.g.,
$,10$(prev_charwould not be defined, and everything crashed). This PR fixes this bug, and modifies test 80 so that it covers the scenario of comma at start of string.