mathtext: Fix bugs in conversion of apostrophes to primes#5880
Merged
mdboom merged 2 commits intomatplotlib:masterfrom Jan 25, 2016
Merged
mathtext: Fix bugs in conversion of apostrophes to primes#5880mdboom merged 2 commits intomatplotlib:masterfrom
mdboom merged 2 commits intomatplotlib:masterfrom
Conversation
This was referenced Jan 19, 2016
Merged
Member
|
This is really minor, but it seems like with the serif font, the |
Member
Author
Member
Author
|
ping @mdboom |
mdboom
added a commit
that referenced
this pull request
Jan 25, 2016
mathtext: Fix bugs in conversion of apostrophes to primes
mdboom
added a commit
that referenced
this pull request
Jan 25, 2016
mathtext: Fix bugs in conversion of apostrophes to primes
Member
|
Backported to v1.5.x as cd866e9 |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
mathtext: Fix bugs in conversion of apostrophes to primes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$''/yr$by recognising apostrophes in first position as part of the superscript.Hlist.extendmethod does not recompute the kerning (so in strings like$f''''(x)$the primes would overrun the parens and the x), so I added anhpack()andkern()calls after extending.I also modified an existing test to include the two bugs fixed.