Allow image comparison outside tests module#5842
Allow image comparison outside tests module#5842WeatherGod merged 2 commits intomatplotlib:masterfrom
Conversation
…ts' module, but issue warning because the code logic seems a bit fragile and may fail.
|
There is one failure in the Travis build but it seems to be the PEP8 issue that was fixed by #5844. Not sure what's making the AppVeyor builds fail to be honest. |
|
power cycled the PR to re-kick CI against current master. |
|
👍 from me once travis passes. This should be non-controversial and I think be backported back to v1.5.x |
tacaswell
modified the milestones:
Critical bug fix release (1.5.2),
proposed next point release (2.1)
|
appveyor failed on a couple of the job runs with a strange error. I can't restart them. |
|
Do not worry about appveyor too, it also lies that it passes ;) On Wed, Jan 13, 2016 at 1:24 PM Benjamin Root notifications@github.com
|
|
Ok. Merging and backporting to v1.5.x. Do I also need to manually backport it to the v2.x branch, or will that happen on its own? |
…e_tests_module Allow image comparison outside tests module
…e_tests_module Allow image comparison outside tests module
|
backported to v1.5.x as 5240759 |
|
every so someone does a 1.5.x -> 2.x -> master cascade |
…son_outside_tests_module Allow image comparison outside tests module
4 participants
This is a replacement for PR #5518 (which should be closed if this is accepted). For now this PR simply removes the
assertstatement so that the@image_comparisondecorator can be used in situations where the test does not live in a parent directory calledtests(this does not apply to matplotlib but will be useful for third-party users).In the medium term it would be good to re-think and refactor the code in
_image_directoriesbecause isn't very easy to read at a glance if you don't know what's going on already, and the logic seems somewhat fragile (see #3314 for example).