X Tutup
Skip to content

Badges#5825

Merged
tacaswell merged 10 commits intomatplotlib:v1.5.xfrom
tacaswell:badges
Jan 10, 2016
Merged

Badges#5825
tacaswell merged 10 commits intomatplotlib:v1.5.xfrom
tacaswell:badges

Conversation

@tacaswell
Copy link
Copy Markdown
Member

Supersedes #5811

screenshot_20160110_134418

@doraf help get the button styled so the fit in with our color theme and get slightly darker on mouse-over.

This PR also includes commits to address some of the issues reproted by @sandrotosi

@tacaswell tacaswell added this to the Critical bugfix release (1.5.1) milestone Jan 10, 2016
@mdboom
Copy link
Copy Markdown
Member

mdboom commented Jan 10, 2016

👍, but it looks like the existing sidebar content is gone...?

@tacaswell
Copy link
Copy Markdown
Member Author

stand by

@tacaswell
Copy link
Copy Markdown
Member Author

screenshot_20160110_144728

Restored the search box and tweaked the style a bit more.

@tacaswell
Copy link
Copy Markdown
Member Author

Unless someone gets to this in the next hour or two I plan to self-merge this to get 1.5.1 tagged today.

This reverts commit f915ac2.

This change breaks the link on every sub-page
@jenshnielsen
Copy link
Copy Markdown
Member

Looks ready to merge once Travis passes 👍

tacaswell added a commit that referenced this pull request Jan 10, 2016
@tacaswell tacaswell merged commit 007a8c8 into matplotlib:v1.5.x Jan 10, 2016
@tacaswell tacaswell deleted the badges branch January 10, 2016 20:55
@tacaswell
Copy link
Copy Markdown
Member Author

self merged after +1 from @mdboom and @jenshnielsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup