👍

I think this fails due to the issue fixed by #5770

Cool. This is very welcome work.

The hash in the inheritance diagrams changes; I guess this is a "bug" in the Sphinx extension, but I have not really looked much deeper.

Looking at the code, nothing obvious leaps out as to why this would be the case... As an experiment, you could try monkey-patching the hash function in sphinx.ext.inheritance_diagram.get_graph_hash to forcibly sort or otherwise normalize the stuff that goes into the hash (and then make a PR against Sphinx if successful -- I'm not suggesting monkey patching it as a matter of course from matplotlib).

There are some dictionaries in attributes and/or default parameters that don't stay sorted. I would assume that's also deep in Sphinx and I can't do anything about it.

If you can reduce this to a simple standalone example where the attributes don't always come out in order, I suspect the Sphinx folks would be amenable to fixing it.

Something is weird with the size of the background of the labels in boxplot_demo2.py; I guess the font size and bbox calculation are not always done in the same order.

I can certainly reproduce this one. I might spend a little time looking.

The location of some tick marks is ever so slightly different in 41 images (including thumbnails and duplicates, so not quite so many actual examples.) I don't know why this is, maybe rounding differences?

Which ones? I wonder if this is due to something not quite right in the recent limits changes or possibly something like #5767

Inheritance diagrams should be fixed by sphinx-doc/sphinx#2210.

Which ones? I wonder if this is due to something not quite right in the recent limits changes or possibly something like #5767

I don't know how these few always come out different somehow, but

• build/html/_images/demo_axis_direction.png
• build/html/_images/demo_axisline_style.png
• build/html/_images/demo_curvelinear_grid1.png
• build/html/_images/demo_curvelinear_grid.png
• build/html/_images/demo_floating_axes1.png
• build/html/_images/demo_floating_axes.png
• build/html/_images/demo_floating_axis1.png
• build/html/_images/demo_floating_axis.png
• build/html/_images/parasite_simple21.png
• build/html/_images/parasite_simple2.png
• build/html/_images/simple_axis_direction01.png
• build/html/_images/whats_new_99_axes_grid.png
  plus whatever other copies of these there are.

I was thinking more of #5647, though.

Looks like this is passing again with the rebase; I think it can go in if there are no other issues and we can leave the other stuff for other PRs.

A few inline comments otherwise 👍 I agree that leaving the other stuff for a subsequent PR is fine.

Looks like the examples that list above are mainly in the mpl_toolkits axes_grid1 and axisartist.
Any change to these may conflict with #5752 which moves these around a bit

@QuLogic If you can address the few line comments we can get this merged. #5752 needs a rebase already so lets get this one in so we can move forward on #5752 and #5743.

If you need to install sphinx from your repo to get that fix.

If you need to install sphinx from your repo to get that fix.

That's fine as long as we remember to rebase that against upstream Sphinx periodically. While I'm normally against monkey-patching, in this case I think I'd prefer monkey patching those two small methods in Sphinx because it places less burden to keep up with Sphinx.

If you need to install sphinx from your repo to get that fix.

Nah, I don't think that's necessary; it only ensures that consecutive builds give consistent names, but it won't make too much difference to the results.

Thanks. We can always fix the examples later then if there are several others with the same issue