Set maximum number of bins in ticking#5724
Conversation
|
👍 I guess we can ignore the appveyor error? |
|
This interacts with #5772 in a safe way, but we should probably centralize this logic in one place or the other. |
|
just thinking out loud, would it make sense to use a logarithm for the On Thu, Dec 31, 2015 at 2:30 PM, Thomas A Caswell notifications@github.com
|
|
On 2015/12/31 9:30 AM, Thomas A Caswell wrote:
If so, the logic definitely belongs in ticker, not in axis. It probably One could go farther, and argue that axis should only supply the |
|
On 2015/12/31 9:44 AM, Benjamin Root wrote:
I don't understand; would you elaborate, please? How would a logarithm |
|
I will rebase my PR on top of this one. |
|
Sorry, I was typing with a baby in one arm...
A hard-set limit to the number of bins would likely be fine in many
situations, but would 9 be enough when the axis is really long? A logarithm
of the axis size could provide a way to have a dynamic maximum bin count
that grows very slowly with size.
|
|
@WeatherGod, I think using a log of the axis size would add more complexity than it would be worth. This is all for trying to automatically make a plot look decent on the screen. The axis size really can't get all that large. The very large case would be something like a poster; but at that point the user is going to need to specify all sorts of things manually anyway. |
|
Any objections to merging this? |
Set maximum number of bins in ticking
|
This is a clear and simple improvement that needs to go in, so I merged it. I suspect that somewhere along the line the tick strategy might need to be revisited, but that needn't block this incremental improvement. |
Follow-on to #5588 based on @efiring's comment that now there can be too many ticks. (#5588 (comment))