Merged
Conversation
tacaswell
added a commit
that referenced
this pull request
Dec 23, 2015
Fix save button in GUIs closes #5689
tacaswell
added a commit
that referenced
this pull request
Dec 23, 2015
Fix save button in GUIs closes #5689
Member
|
back ported as 2695ea5 |
This was referenced Dec 23, 2015
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The save button in GUIs currently raises an exception that
'figure' can not be converted to floatbecause the special value ofsavefig.dpi==figureis not handled everywhere.This bug was introduced in #4286, but not really easily triggered until we changed the default in #5659.
This should probably be backported (I didn't realise the bug is also on 1.5.x until further inspection).