WX/WXagg backend add code that zooms properly on a Mac with a Retina display#5631
Conversation
…d self.canvas.draw() call in the FigureManagerWx.show() method comes from the Canopy dist
jenshnielsen
changed the title
|
Thanks, I will try to take a look later. Last time I checked it was not fixed in Phoenix I think it is a bug in Wx and not the python bindings |
tacaswell
modified the milestones:
Critical bugfix release (1.5.1),
next bug fix release (2.0.1)
|
I'll review the change today as well. |
|
It looks good to me, other than a style mismatch ( In addition, it looks like there is an undocumented method in wx that can be called to help determine if retina is currently in use for a window or a DC. It's not wrapped by wxPython yet but I'll get it added and try to get at least a preview build done soon so it can be tested. In the meantime you may want to add a reminder comment in the code that when |
|
Hmmm, travis failure makes no sense. Passed that before and error messages seem unconnected to the one file I changed. What gives? |
|
It is a spurious LaTeX error that we get sometimes on Travis. I restarted that particular test. |
|
Tests now pass. I don't have a retina display, so I can't do much else. I'll leave this up to one of the other devs to finalize. |
WX/WXagg backend add code that zooms properly on a Mac with a Retina display
WX/WXagg backend add code that zooms properly on a Mac with a Retina display
|
backported to 1.5.x as 911f349 |
QuLogic
modified the milestones:
Critical bugfix release (1.5.1),
next bug fix release (2.0.1)
6 participants
This uses a slower method for drawing the zoom rubberband box on all Macs (perhaps not needed in Phoenix?) because I don't know a way to detect if a Retina display is present.
Note that the added self.canvas.draw() call in the FigureManagerWx.show() method comes from the version in the Canopy dist for 1.5.0.