X Tutup
Skip to content

Fixes #5522, bug in custom scale example#5533

Merged
tacaswell merged 2 commits intomatplotlib:masterfrom
jeffrey-hokanson:master
Nov 20, 2015
Merged

Fixes #5522, bug in custom scale example#5533
tacaswell merged 2 commits intomatplotlib:masterfrom
jeffrey-hokanson:master

Conversation

@jeffrey-hokanson
Copy link
Copy Markdown
Contributor

Added the property has_inverse = True to the custom scale example so that if axhline is later called on this axis an error is not produced.

Added the property has_inverse = True to the custom scale example
so that if axhline is later called on this axis an error is not
produced.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a PEP8 nitpick here: Insert a blank space before the method definition.

@mdboom
Copy link
Copy Markdown
Member

mdboom commented Nov 20, 2015

Other than the PEP8 failure, looks good to me.

@mdboom mdboom added this to the Critical bugfix release (1.5.1) milestone Nov 20, 2015
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this and the file appears clear upon running pep8. Is there something else I'm missing?

tacaswell added a commit that referenced this pull request Nov 20, 2015
Fixes #5522, bug in custom scale example
@tacaswell tacaswell merged commit 7f46613 into matplotlib:master Nov 20, 2015
@tacaswell
Copy link
Copy Markdown
Member

@jeffrey-hokanson Thanks! Congratulations on (what I think) is your first contribution to mpl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup