X Tutup
Skip to content

fix small typo in documentation about CheckButtons.#5484

Merged
tacaswell merged 5 commits intomatplotlib:masterfrom
flothesof:patch-1
Nov 24, 2015
Merged

fix small typo in documentation about CheckButtons.#5484
tacaswell merged 5 commits intomatplotlib:masterfrom
flothesof:patch-1

Conversation

@flothesof
Copy link
Copy Markdown
Contributor

Just a little typo.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Nov 16, 2015

There are actually several of this same typo all over the file; do you mind fixing them at the same time?

@flothesof
Copy link
Copy Markdown
Contributor Author

@QuLogic I added some more corrections as requested. There's still a FIXME left because I couldn't figure what the original author meant.

@tacaswell
Copy link
Copy Markdown
Member

👍

Thanks for cleaning up by copy-paste typo 🐑

@tacaswell tacaswell added this to the Critical bugfix release (1.5.1) milestone Nov 16, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you fixed the other truncated comment; any ideas what goes here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess this is the one you meant in the original comment, then.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. That's what I meant.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, I remember adding that comment as a bit of a joke...

tacaswell added a commit that referenced this pull request Nov 24, 2015
DOC: fix small typos in documentation
@tacaswell tacaswell merged commit 380a894 into matplotlib:master Nov 24, 2015
@tacaswell
Copy link
Copy Markdown
Member

Merging this as it clearly improves things 👍

@flothesof If you want to keep fixing up the docs (which is awesome btw), please open a new PR.

I think this is your first mpl contribution; congratulations and thank you!

tacaswell added a commit that referenced this pull request Nov 24, 2015
DOC: fix small typos in documentation
@tacaswell
Copy link
Copy Markdown
Member

backported as aceb626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup