X Tutup
Skip to content

Fixed issue with rasterized not working for errorbar#5466

Merged
WeatherGod merged 1 commit intomatplotlib:masterfrom
orso82:master
Dec 31, 2015
Merged

Fixed issue with rasterized not working for errorbar#5466
WeatherGod merged 1 commit intomatplotlib:masterfrom
orso82:master

Conversation

@orso82
Copy link
Copy Markdown
Contributor

@orso82 orso82 commented Nov 11, 2015

This pull request fixes the rasterized argument not being passed to the lines of the errorbar

@mdboom mdboom added this to the Critical bugfix release (1.5.1) milestone Nov 12, 2015
@mdboom
Copy link
Copy Markdown
Member

mdboom commented Nov 12, 2015

It looks like this just needs to be cleaned up for PEP8 (too long lines), but otherwise, I'm 👍. We should also add a test. I don't think an image comparison test will pick this up (since the rasterized version should be close enough to a non-rasterized one). But you could create an errorbar with rasterized set to True and then just introspect that get_rasterized on the artists returns True.

@tacaswell
Copy link
Copy Markdown
Member

@orso82 Any update on this?

@tacaswell tacaswell mentioned this pull request Dec 31, 2015
@WeatherGod WeatherGod merged commit 2b66c27 into matplotlib:master Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup