Faster event delegation in WebAgg/NbAgg backends#5385
Merged
pelson merged 1 commit intomatplotlib:masterfrom Nov 3, 2015
Merged
Faster event delegation in WebAgg/NbAgg backends#5385pelson merged 1 commit intomatplotlib:masterfrom
pelson merged 1 commit intomatplotlib:masterfrom
Conversation
The if/else block is slower than a dictionary lookup/method call
Member
|
How much does this speed things up? |
pelson
added a commit
that referenced
this pull request
Nov 3, 2015
Faster event delegation in WebAgg/NbAgg backends
Member
Given we're talking about sending PNGs over http I'd be amazed if this were measurable. Despite that, 👍 from me as it tidies up the code nicely. |
Member
Author
|
I was able to peak about 15 fps with this, 13 without. Not much, but not nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The if/else block is slower than a dictionary lookup/method call