Closed
Conversation
On topic: matplotlib#5350
Member
|
This looks great, and congrats on your first matplotlib pull request! It would be nice to add a test -- i.e. something that failed before this change but works after it. There's information on writing tests here, but let us know if you have any questions. |
Author
|
thanks Michael, as user it's really nice to contribute somehow even in as simple issue like this. I'll prepare a test based on what I was doing when found the problem. |
Member
|
@jcolonese Any update on the test? |
Merged
Member
|
@jcolonese A commit with identical content was merged in #7520 , sorry this fell by the wayside. I am going to close this as it has been superseded, hopefully we will here from you again! |
QuLogic
modified the milestones:
2.0 (style change major release),
2.0.1 (next bug fix release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On topic: #5350