X Tutup
Skip to content

FIX: subtle race condition in cbook.mkdirs #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenshnielsen merged 3 commits into from
Oct 13, 2015
Merged

FIX: subtle race condition in cbook.mkdirs #5224

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf6816d
FIX: subtle race condition in cbook.mkdirs
tacaswell Oct 12, 2015
ceaa7de
MNT: simplify legacy python codepath
tacaswell Oct 12, 2015
151db47
MNT: slightly re-arrange logic
tacaswell Oct 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions lib/matplotlib/cbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,19 +1012,16 @@ def mkdirs(newdir, mode=0o777):
> mkdir -p NEWDIR
> chmod MODE NEWDIR
"""
try:
if not os.path.exists(newdir):
parts = os.path.split(newdir)
for i in range(1, len(parts) + 1):
thispart = os.path.join(*parts[:i])
if not os.path.exists(thispart):
os.makedirs(thispart, mode)

except OSError as err:
# Reraise the error unless it's about an already existing directory
if err.errno != errno.EEXIST or not os.path.isdir(newdir):
raise

# this functionality is now in core python as of 3.2
# LPY DROP
if six.PY3:
os.makedirs(newdir, mode=mode, exist_ok=True)
else:
try:
os.makedirs(newdir, mode=mode)
except OSError as exception:
if exception.errno != errno.EEXIST:
raise

class GetRealpathAndStat(object):
def __init__(self):
Expand Down
X Tutup