Reduce AutoDateFormatter precision when possible#4809
Closed
matthijskooijman wants to merge 1 commit intomatplotlib:masterfrom
Closed
Reduce AutoDateFormatter precision when possible#4809matthijskooijman wants to merge 1 commit intomatplotlib:masterfrom
matthijskooijman wants to merge 1 commit intomatplotlib:masterfrom
Conversation
Previously, the AutoDateFormatter would choose a format with second or microsecond precision, even when the ticks were significantly coarser than that. The resulting extra precision looks weird and can clutter the display (especially with the long microsecond display). This commit changes the default scale to format dictionary, which now works as follows: - Use microsecond precision when the ticks are less than a second apart - Use second precision when the ticks are seconds apart - Use minute precision when the ticks are minutes or hours apart - Use day-precision, month or year precision when the ticks are days or more apart (unchanged). Note that there is no point in displaying only the hour when the ticks are hours apart, since then it won't be immediately clear that a time is being displayed. Adding the (technically superfluous) :00 for the minutes should make it immediately obvious that a time is being displayed, which is why the minute precision should also be used when the ticks are hours apart. While updating the documentation for this change, it was also changed to use symbolic constants instead of hardcoded numbers. This should make it more clear what the intention is. Closes: matplotlib#4808
Author
|
Note that this pullrequest has not been tested as-is, since I don't have time right now to set up a full matplotlib build from git. I did test the changes backported into 1.4.3, which works as expected. |
Member
There was a problem hiding this comment.
This part is a doc-string, so perhaps it doesn't make sense to use the global variables here?
Author
There was a problem hiding this comment.
I would say it makes the documentation more clear like this? Also, expanding MUSECONDS_PER_DAY would result in 1. / (24 * 60 * 60 * 1000000), which struck me as overly complicated. But I'm happy to change back to numbers if you think that would be better?
Member
There was a problem hiding this comment.
fair enough. I'll let others weigh in with their preference.
Member
There was a problem hiding this comment.
I think the globals as much more readable.
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Nov 8, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 11, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 16, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 16, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 17, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 23, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 25, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 27, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Nov 27, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 14, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 14, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
Member
|
Would it make sense to just combine this with #5445, @tacaswell? |
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 14, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 17, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 31, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 31, 2015
- Use ISO complient formats by default - aded extra level of scale (seconds) - add rcparams for all of these strings closes matplotlib#4808 closes matplotlib#4809 closes matplotlib#5086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the AutoDateFormatter would choose a format with second or
microsecond precision, even when the ticks were significantly coarser
than that. The resulting extra precision looks weird and can clutter the
display (especially with the long microsecond display).
This commit changes the default scale to format dictionary, which now
works as follows:
apart (unchanged).
Note that there is no point in displaying only the hour when the ticks are
hours apart, since then it won't be immediately clear that a time is being
displayed. Adding the (technically superfluous) :00 for the minutes should
make it immediately obvious that a time is being displayed, which is why the
minute precision should also be used when the ticks are hours apart.
While updating the documentation for this change, it was also changed to use
symbolic constants instead of hardcoded numbers. This should make it more clear
what the intention is.
Closes: #4808