Remove test dependencies from install_requires #4668
Merged
tacaswell merged 8 commits intomatplotlib:masterfrom Jul 14, 2015
Merged
Remove test dependencies from install_requires #4668tacaswell merged 8 commits intomatplotlib:masterfrom
tacaswell merged 8 commits intomatplotlib:masterfrom
Conversation
- add setup.py test command for test execution - modify setupext's logic for dependency determination for a test requirements list - add nose to test requirements - update documentation accordingly This reverts commit 3d622fe. install mock for dock building
It is more informative to raise the error here
Member
|
Looking at this again (I was only looking at the previous version of this PR for "correctness"). I have serious reservations about this PR. As I discussed offline with @jenshnielsen , matplotlib comes with a Probably at the very least, the test() function should detect the import failure and provide a very clear and simple message informing users to install nose/mock. |
And print an informative message
This was referenced Jul 13, 2015
tacaswell
added a commit
that referenced
this pull request
Jul 14, 2015
TST: Remove test dependencies from install_requires
This was referenced Jul 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes for #4188