Change default interpolation to nearest by jenshnielsen · Pull Request #4622 · matplotlib/matplotlib

jenshnielsen · 2015-07-10T23:09:33Z

As discussed in the Scipy BOF I propose changing the default interpolation of imshow to nearest.

I haven't yet refreshed any of the tests. So this will likely fail.

jenshnielsen · 2015-07-10T23:32:20Z

Need to refresh the following tests

matplotlib.tests.test_axes.test_specgram_angle_freqs.test
matplotlib.tests.test_axes.test_specgram_magnitude_noise.test
matplotlib.tests.test_axes.test_specgram_magnitude_noise.test
matplotlib.tests.test_axes.test_specgram_noise.test
matplotlib.tests.test_axes.test_specgram_noise.test
matplotlib.tests.test_axes.test_specgram_noise_angle.test
matplotlib.tests.test_backend_svg.test_noscale.test
matplotlib.tests.test_backend_svg.test_noscale.test
matplotlib.tests.test_image.test_image_clip.test
matplotlib.tests.test_image.test_image_clip.test
matplotlib.tests.test_image.test_image_clip.test
matplotlib.tests.test_image.test_image_cliprect.test
matplotlib.tests.test_image.test_image_cliprect.test
matplotlib.tests.test_image.test_image_cliprect.test
matplotlib.tests.test_image.test_image_composite_background.test
matplotlib.tests.test_image.test_image_composite_background.test
matplotlib.tests.test_image.test_image_composite_background.test
matplotlib.tests.test_image.test_rasterize_dpi.test
matplotlib.tests.test_image.test_rasterize_dpi.test
matplotlib.tests.test_patheffects.test_patheffect1.test
matplotlib.tests.test_patheffects.test_patheffect1.test
matplotlib.tests.test_patheffects.test_patheffect1.test
matplotlib.tests.test_patheffects.test_patheffect2.test
matplotlib.tests.test_patheffects.test_patheffect2.test matplotlib.tests.test_patheffects.test_patheffect2.test mpl_toolkits.tests.test_axes_grid.test_imagegrid_cbar_mode_edge.test

efiring · 2015-07-11T01:12:32Z

Changing to "nearest" makes sense to me; I have never seen the present default as useful.

tacaswell · 2015-07-11T04:47:38Z

👍

maxalbert · 2015-07-13T15:58:36Z

lib/matplotlib/image.py

Should the comma be removed between "nearest" and "and 'bilinear'"?

@maxalbert yes

mdboom · 2015-07-13T16:47:28Z

I agree with this change. However, the one downside is that it will increase file sizes for the vector backends (since the data will now be upsampled to the output resolution). We should probably include that as a note in the "What's new" about this change.

WeatherGod · 2015-07-13T16:51:22Z

Doesn't that depend on whether the default is 'none' versus 'nearest'?

On Mon, Jul 13, 2015 at 12:47 PM, Michael Droettboom <
notifications@github.com> wrote:

I agree with this change. However, the one downside is that it will
increase file sizes for the vector backends (since the data will now be
upsampled to the output resolution). We should probably include that as a
note in the "What's new" about this change.

—
Reply to this email directly or view it on GitHub
#4622 (comment)
.

mdboom · 2015-07-13T17:13:43Z

@WeatherGod: You're right. Ignore my comment.

astrofrog · 2015-07-20T06:27:18Z

👍 for changing to nearest by default

jradavenport · 2015-10-05T18:14:12Z

👍 for nearest. I'm seeing more and more figures making it in to published literature using 'none', which are unreadable. Changing this default would promote best-practices for scientific figures.

CLN: Remove various Python 2.6 related workarounds

Fix matplotlib#347: Faster text rendering in Agg

FIX: Apply asanyarray to arguments for pcolor and family

DOC: correct indentation

…ndent Merge pull request matplotlib#5407 from tacaswell/doc_boxplot

MNT: Remove uses of font.get_charmap Conflicts: lib/matplotlib/tests/test_font_manager.py Conflicts with merging the tests, resloved to add only relavent code.

Merge pull request matplotlib#5410 from mdboom/get-charmap-removal

Use a specific version of Freetype for testing

jenshnielsen · 2015-11-06T11:34:38Z

replaced by #5416 against the correct branch and with the typo fixed

jenshnielsen added API: default changes topic: rcparams labels Jul 10, 2015

jenshnielsen added this to the next major release milestone Jul 10, 2015

tacaswell added the status: needs review label Jul 10, 2015

jenshnielsen mentioned this pull request Jul 10, 2015

Followup items from the matplotlib 2.0 BoF #4614

Closed

4 tasks

jenshnielsen force-pushed the default_interpolation branch from a37968a to 6dff273 Compare July 10, 2015 23:12

jenshnielsen added the status: needs revision label Jul 10, 2015

tacaswell modified the milestones: next major release, Color overhaul Jul 11, 2015

maxalbert reviewed Jul 13, 2015
View reviewed changes

Apply asanyarray to arguments for pcolor and family

df6e1ac

tacaswell modified the milestones: Color overhaul, next major release (2.0) Oct 26, 2015

tacaswell and others added 5 commits November 4, 2015 22:50

Merge pull request matplotlib#5373 from jenshnielsen/python26removal

1866a8c

CLN: Remove various Python 2.6 related workarounds

Merge pull request matplotlib#5361 from mdboom/fast-text

a340827

Fix matplotlib#347: Faster text rendering in Agg

Merge pull request matplotlib#5206 from WeatherGod/fix_5205

bf0ca5a

FIX: Apply asanyarray to arguments for pcolor and family

Merge pull request matplotlib#5407 from tacaswell/doc_boxplot

830ad62

DOC: correct indentation

Merge pull request matplotlib#5408 from jenshnielsen/backportboxploti…

46e9f22

…ndent Merge pull request matplotlib#5407 from tacaswell/doc_boxplot

tacaswell and others added 7 commits November 5, 2015 11:29

Merge pull request matplotlib#5410 from mdboom/get-charmap-removal

c9fbfab

MNT: Remove uses of font.get_charmap Conflicts: lib/matplotlib/tests/test_font_manager.py Conflicts with merging the tests, resloved to add only relavent code.

Merge pull request matplotlib#5412 from tacaswell/cp_font_cmap

c22614e

Merge pull request matplotlib#5410 from mdboom/get-charmap-removal

Merge pull request matplotlib#5306 from mdboom/local-freetype

d730481

Use a specific version of Freetype for testing

Merge branch 'v1.5.x' into v2.0.x

bf51375

Change default image interpolation to nearest

0522413

Change docstring to reflect new default interpolation

7623a6f

fix typo

dd2cb75

jenshnielsen force-pushed the default_interpolation branch from 6dff273 to dd2cb75 Compare November 6, 2015 11:32

jenshnielsen mentioned this pull request Nov 6, 2015

Change default interpolation to nearest #5416

Closed

jenshnielsen closed this Nov 6, 2015

tacaswell removed status: needs review status: needs revision labels Nov 6, 2015

QuLogic added the status: duplicate label Oct 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change default interpolation to nearest#4622

Change default interpolation to nearest#4622
jenshnielsen wants to merge 13 commits intomatplotlib:masterfrom
jenshnielsen:default_interpolation

jenshnielsen commented Jul 10, 2015

Uh oh!

jenshnielsen commented Jul 10, 2015

Uh oh!

efiring commented Jul 11, 2015

Uh oh!

tacaswell commented Jul 11, 2015

Uh oh!

maxalbert Jul 13, 2015

Uh oh!

endolith Jul 19, 2015

Uh oh!

mdboom commented Jul 13, 2015

Uh oh!

WeatherGod commented Jul 13, 2015

Uh oh!

mdboom commented Jul 13, 2015

Uh oh!

astrofrog commented Jul 20, 2015

Uh oh!

jradavenport commented Oct 5, 2015

Uh oh!

jenshnielsen commented Nov 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

jenshnielsen commented Jul 10, 2015

Uh oh!

jenshnielsen commented Jul 10, 2015

Uh oh!

efiring commented Jul 11, 2015

Uh oh!

tacaswell commented Jul 11, 2015

Uh oh!

maxalbert Jul 13, 2015

Choose a reason for hiding this comment

Uh oh!

endolith Jul 19, 2015

Choose a reason for hiding this comment

Uh oh!

mdboom commented Jul 13, 2015

Uh oh!

WeatherGod commented Jul 13, 2015

Uh oh!

mdboom commented Jul 13, 2015

Uh oh!

astrofrog commented Jul 20, 2015

Uh oh!

jradavenport commented Oct 5, 2015

Uh oh!

jenshnielsen commented Nov 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants