BUG : correct default value alpha on legend patch#3773
Merged
jenshnielsen merged 2 commits intomatplotlib:v1.4.xfrom Dec 30, 2014
Merged
BUG : correct default value alpha on legend patch#3773jenshnielsen merged 2 commits intomatplotlib:v1.4.xfrom
jenshnielsen merged 2 commits intomatplotlib:v1.4.xfrom
Conversation
Fixes matplotlib#3766 Adding `legend.framealpha` in matplotlib#3369 changed the default value of alpha on the legend patch from `None` -> 1 which has no visual effect as `to_rgba` defaults to alpha=1 if no alpha is passed, but this overrides setting the alpha component via `set_facecolor(rgba_value)`. This PR - addes a new validation function `validate_float_or_None` - changes legend.framealpha to default to `None` - adds test that with the default value of `legend.framealpha` the alpha value of the face can be set via a rgba value - adds tests that setting the framealpha to a non-None value ignores the alpha value passed to set_facecolor
Member
Author
|
Can I review my own PR if I don't immediately remember writing it? |
jenshnielsen
added a commit
that referenced
this pull request
Dec 30, 2014
BUG : correct default value alpha on legend patch
Member
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3766
Adding
legend.framealphain #3369 changed the default value ofalpha on the legend patch from
None-> 1 which has no visual effectas
to_rgbadefaults to alpha=1 if no alpha is passed, but thisoverrides setting the alpha component via
set_facecolor(rgba_value).This PR
validate_float_or_NoneNonelegend.framealphathe alpha value of the face can be set via a rgba value
ignores the alpha value passed to set_facecolor