Conversation
|
👍, assuming Travis passes. |
|
@jenshnielsen do you mind if we merge this? This looks good to me, and @mdboom already gave a 👍 |
|
I am slightly nervous of doing this just before release without more careful testing on different platforms. But I will leave that up to you. I don't know what @tacaswell thinks? |
|
I have changed this a bit to more closely match the original. This should reduce the risk of issues on other platforms. I think this should be ready to go now if travis passes (only on master) |
This ensures that file handles are cloesed
|
Rebased |
|
Do we want to cherry-pick this to the 1.4.x branch? I don't think we want to do it for 1.4.0, but it might be good to do eventually. |
|
Sure. I'll go ahead and cherry-pick this. |
|
As discussed at SciPY I agree with @tacaswell that these warning fixes don't need to go into 1.4.0 btw would you prefer to have all these on the same branch. I am happy to combine #3241, #3244, #3282 etc. into one pull request. |
Silence some more warnings
4 participants
This is not ready for merge yet. But I would like to get a travis test running