X Tutup
Skip to content

Fix lots of warnings in docs/Examples that crash#3224

Merged
tacaswell merged 2 commits intomatplotlib:masterfrom
mdboom:documentation-glitches
Jul 12, 2014
Merged

Fix lots of warnings in docs/Examples that crash#3224
tacaswell merged 2 commits intomatplotlib:masterfrom
mdboom:documentation-glitches

Conversation

@mdboom
Copy link
Copy Markdown
Member

@mdboom mdboom commented Jul 11, 2014

Fix some examples that crash.

Doesn't get all the warnings, but a significant fraction. (Let's automate the doc build! 👍)

@mdboom mdboom added this to the v1.4.0 milestone Jul 11, 2014
Fix some examples that crash.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The former is the 'open-close-high-low' order of quotes used previously in this module, and the latter is the 'open-high-low-close' order that is standard in finance."
That alternative version of the sentence fixes several little errors.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I was really just limiting myself to formatting changes, but we might as well fix this while we're at it.

@tacaswell
Copy link
Copy Markdown
Member

I am a bit worried that this is going to clash in a very bad way with #3170....

@tacaswell
Copy link
Copy Markdown
Member

Although, this merges cleanly into that one. We apparently fixed different brokenness in the docs.

@NelleV
Copy link
Copy Markdown
Member

NelleV commented Jul 12, 2014

That looks good. My policy when it comes to conflicting PR is the first one in wins, and the other one deals with conflicts, but I'll let someone push the green button (which is grey thanks to travis failing).

@mdboom
Copy link
Copy Markdown
Member Author

mdboom commented Jul 12, 2014

Sure -- we can merge/address conflicts in whatever makes sense for everyone else.

tacaswell added a commit that referenced this pull request Jul 12, 2014
Fix lots of warnings in docs/Examples that crash
@tacaswell tacaswell merged commit 2bdf314 into matplotlib:master Jul 12, 2014
@mdboom mdboom deleted the documentation-glitches branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup