X Tutup
Skip to content

MNT: Minor cleanup of label formatting in PathCollection.legend_elements #31412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timhoffm wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

MNT: Minor cleanup of label formatting in PathCollection.legend_elements #31412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/matplotlib/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,15 @@ def legend_elements(self, prop="colors", num="auto",
"alpha": self.get_alpha(),
**kwargs}

for val, lab in zip(values, label_values):
# Pre-format all labels
# TODO: check whether we can switch to
# formatted_labels = fmt.format_ticks(label_values)
# There are subtle differences for some formatters as that passes the
# indices to __call__ as well.
fmt.set_locs(label_values)
formatted_labels = [fmt(lab) for lab in label_values]

for val, formatted in zip(values, formatted_labels):
if prop == "colors":
color = self.cmap(self.norm(val))
elif prop == "sizes":
Expand All @@ -1281,10 +1289,7 @@ def legend_elements(self, prop="colors", num="auto",
h = mlines.Line2D([0], [0], ls="", color=color, ms=size,
marker=self.get_paths()[0], **kw)
handles.append(h)
if hasattr(fmt, "set_locs"):
fmt.set_locs(label_values)
l = fmt(lab)
labels.append(l)
labels.append(formatted)

return handles, labels

Expand Down
Loading
X Tutup