X Tutup
Skip to content

Enable path simplification for FillBetweenPolyCollection to reduce vector output size #31361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saitejaponnam12 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −0
Open

Enable path simplification for FillBetweenPolyCollection to reduce vector output size #31361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
235c6be
Enable path simplification for FillBetweenPolyCollection to reduce ve…
saitejaponnam12 Mar 24, 2026
b730263
Respect rcParams when enabling path simplification for FillBetweenPol…
saitejaponnam12 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/matplotlib/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,6 +1444,16 @@ def __init__(
verts = self._make_verts(t, f1, f2, where)
super().__init__(verts, **kwargs)

def set_verts(self, verts, closed=True):
super().set_verts(verts, closed=closed)

# Respect global path simplification setting
simplify = bool(mpl.rcParams.get("path.simplify", True))
for path in self._paths:
path.should_simplify = simplify

set_paths = set_verts
Comment on lines +1447 to +1455
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As implemented, setting Path.should_simplify here likely won’t reduce SVG/PDF output size for fill_between: vector backends emit collection templates with simplify=False (e.g., SVG draw_path_collection and PDF writePathCollectionTemplates), so the backend never consults path.should_simplify for these polygons. If the goal is smaller vector output, the simplification flag probably needs to be plumbed into the relevant template-writing code paths (or those code paths should pass simplify=None so should_simplify is honored).

Copilot uses AI. Check for mistakes.

@staticmethod
def _f_dir_from_t(t_direction):
"""The direction that is other than `t_direction`."""
Expand Down
Loading
X Tutup