Reword the "fully-new contributor" section.#31204
Merged
story645 merged 1 commit intomatplotlib:mainfrom Feb 26, 2026
Merged
Conversation
timhoffm
approved these changes
Feb 26, 2026
Member
|
Leaving still open to give @story645 the chance for feedback. |
Member
|
Also attn @melissawm |
story645
added
the
DO NOT MERGE
tacaswell
approved these changes
Feb 26, 2026
story645
reviewed
Feb 26, 2026
Member
story645
left a comment
story645
left a comment
There was a problem hiding this comment.
I think your initial wording is great, I'm just thinking we may as well go all in on explicit/expectation setting.
story645
reviewed
Feb 26, 2026
story645
reviewed
Feb 26, 2026
Member
story645
left a comment
story645
left a comment
There was a problem hiding this comment.
github apparently split my review in two
anntzer
force-pushed
the
newcontrib
branch
2 times, most recently
from
9266d15 to
f6d89ae
Compare
story645
reviewed
Feb 26, 2026
story645
removed
the
DO NOT MERGE
Essentially, one should either be a Matplotlib user, or a domain (visualization, statistics, technical writing/documentation, etc.) expert, to make a meaningful contribution. Also remove the "Take a look at the following section" sentence which adds nothing.
story645
approved these changes
Feb 26, 2026
Member
|
Thanks for putting this in @anntzer! I appreciate it as much as any code contribution. |
Hannan7812
pushed a commit
to Hannan7812/matplotlib
that referenced
this pull request
Feb 27, 2026
Essentially, one should either be a Matplotlib user, or a domain (visualization, statistics, technical writing/documentation, etc.) expert, to make a meaningful contribution. Also remove the "Take a look at the following section" sentence which adds nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially, one should either be a Matplotlib user, or a domain (visualization, statistics, technical writing/documentation, etc.) expert, to make a meaningful contribution. (I also think that reading issues/PRs without having ever used the library is nonsensical.)
Also remove the "Take a look at the following section" sentence which adds nothing.
Extracted from the discussion starting at #29686 (comment) (attn @story645 @timhoffm); triggered by the recent issues linked to the new GSOC season...
PR summary
AI Disclosure
PR checklist