If you want to change the api and defaults for bxp go right ahead, it is just the defaults when called via boxplot that can't change. You can put the logic to generate the old defaults in boxplot and pass them through to bxp. You have to write the default handling code twice, but it makes everyone happy(ish).

Thanks for the feedback, Thomas.

Looks like I fell victim to my crappy trackpad randomly highlighting and
text as I was typing that out on a recent flight. Will fix soon.

On Fri, May 16, 2014 at 5:57 AM, Thomas A Caswell
notifications@github.comwrote:

If you want to change the api and defaults for bxp go right ahead, it is
just the defaults when called via boxplot that can't change. You can put
the logic to generate the old defaults in boxplot and pass them through
to bxp. You have to write the default handling code twice, but it makes
everyone happy(ish).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3066#issuecomment-43327753
.

Figured it was something like that.

I feel you on issues with trackpads...

@phobson Any progress on this?

Will wrap up this weekend. Promise. --
Paul Hobson
Sorry if this is unintelligible. I'm on my phone.

On Wed, May 28, 2014 at 9:04 PM, Thomas A Caswell
notifications@github.com wrote:

@phobson Any progress on this?

Reply to this email directly or view it on GitHub:
#3066 (comment)

@phobson Thoughts on the test failures?

I spent a lot of time troubleshooting them.

1. stackplot is failing in all cases, so hopefully a rebase will fix that.
2. I narrowed it down to the tests that involved horizontal boxplots.

What's weird is that enabling those tests cause failures in unrelated
boxplot/bxp tests. Comment them out, only test_stackplot fails.

Still wrapping my brain around this.

On Mon, Jun 9, 2014 at 6:05 PM, Thomas A Caswell notifications@github.com
wrote:

@phobson https://github.com/phobson Thoughts on the test failures?

—
Reply to this email directly or view it on GitHub
#3066 (comment)
.

do they also fail if you run the tests in series? What do the test images look like?

@phobson I am somewhat confused, there is a lot more new code in this than I expected there to be. Why did capprops and whiskerprops get added?

@phobson The issue is that the doplot function expects that *args will have an even length (so that the shuffling works correctly), but when do_plot is used for the fliers sym is also passed in as a positional argument so the length of args is odd which is the source of the errors.

The rest of the fails were taken care of by a re-base.

closing this in favor of #3165 for tidyness. We can always re-open this one/close that one later.