MultiNorm class by trygvrad · Pull Request #29876 · matplotlib/matplotlib

trygvrad · 2025-04-06T14:05:33Z

PR summary

This PR continues the work of #28658 and #28454, aiming to close #14168. (Feature request: Bivariate colormapping)

This is part one of the former PR, #29221. Please see #29221 for the previous discussion

Features included in this PR:

A MultiNorm class. This is a subclass of colors.Normalize and holds n_variate norms.
Testing of the MultiNorm class

Features not included in this PR:

changes to colorizer.py needed to expose the MultiNorm class
Exposes the functionality provided by MultiNorm together with BivarColormap and MultivarColormap to the plotting functions axes.imshow(...), axes.pcolor, and `axes.pcolormesh(...)
Testing of the new plotting methods
Examples in the docs

lib/matplotlib/colors.py

lib/matplotlib/scale.py

lib/matplotlib/colors.py

lib/matplotlib/colors.pyi

lib/matplotlib/colors.py

anntzer

Just some minor points, plus re-pinging @timhoffm in case he has an opinion re: n_input / input_dims naming?

trygvrad · 2025-05-04T09:14:39Z

Thank you for the feedback @anntzer !
Hopefully we can hear if @timhoffm has any thoughts on n_input / input_dims naming within the coming week.

timhoffm · 2025-05-05T11:41:04Z

See #29876 (comment)

trygvrad · 2025-05-07T17:57:37Z

Thank you @timhoffm
The PR should now be as we agreed (#29876 (comment)) :)

lib/matplotlib/colors.py

trygvrad · 2025-06-01T11:37:52Z

@QuLogic Thank you again and apologies for my tardiness (I was sick)
@timhoffm Do you think you could approve this PR now?

lib/matplotlib/colors.py

trygvrad · 2025-06-06T16:12:24Z

This is on hold until we sort out #30149 (Norm Protocol)
see #29876 (comment)

trygvrad · 2025-08-01T11:00:47Z

I changed vmin, vmax and clip to only accept iterables or None.

It dawned on me that it will be useful to allow None, with the behavior that it does not modify the vmin/vmax/clip on the constituent norms. This will be useful for use as a default, but also be useful for users that want to combine multiple norms into a MultiNorm without modifying the limits of the norms.

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

lib/matplotlib/colors.py

anntzer · 2025-08-01T12:25:32Z

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

Sorry I dropped the ball on this. I can try to have a look but not before the middle of the month or so.

lib/matplotlib/colors.py

lib/matplotlib/colors.pyi

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

trygvrad · 2025-08-14T10:31:43Z

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

QuLogic · 2025-08-15T01:02:02Z

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

There are still a couple of comments that are unresolved/have no reply, at least.

trygvrad · 2025-08-15T09:06:41Z

@QuLogic @story645 thank you for your comments and patience on this, I believe i have addressed all the comments now, but please correct me again if there are some I have overlooked. Otherwise I look forward to your future comments :)

lib/matplotlib/colors.py

lib/matplotlib/tests/test_colors.py

lib/matplotlib/colors.py

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

QuLogic

Just a minor last thing,

lib/matplotlib/colors.py

lib/matplotlib/colors.pyi

trygvrad · 2025-08-20T09:16:25Z

Just a minor last thing,

Thank you @QuLogic !

QuLogic

Were you expecting a squash merge?

trygvrad · 2025-08-20T23:21:13Z

Were you expecting a squash merge?

Yes, I believe a squash merge would be most suitable

QuLogic · 2025-08-20T23:39:26Z

Thanks for working your way through this long process.

github-actions bot added topic: color/color & colormaps topic: transforms and scales labels Apr 6, 2025

This was referenced Apr 6, 2025

Preparations for multivariate plotting #29877

Closed

Multivariate plotting in imshow, pcolor and pcolormesh #29221

Closed

oscargus reviewed Apr 6, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

oscargus reviewed Apr 6, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

oscargus reviewed Apr 6, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed Apr 7, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed Apr 7, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed Apr 7, 2025

View reviewed changes

lib/matplotlib/scale.py Outdated Show resolved Hide resolved

github-actions bot removed the topic: transforms and scales label Apr 10, 2025

QuLogic reviewed Apr 17, 2025

View reviewed changes

trygvrad force-pushed the multivariate-plot-prapare branch from 55b85e3 to f42d65b Compare April 17, 2025 15:18

anntzer reviewed May 1, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed May 1, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed May 1, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed May 1, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

anntzer reviewed May 1, 2025

View reviewed changes

QuLogic reviewed May 23, 2025

View reviewed changes

timhoffm reviewed Jun 2, 2025

View reviewed changes

QuLogic reviewed Jun 4, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

trygvrad force-pushed the multivariate-plot-prapare branch from 6b86d63 to 32247f5 Compare June 4, 2025 21:01

trygvrad mentioned this pull request Jun 6, 2025

Creation of the Norm Protocol #30149

Closed

story645 added the status: waiting for other PR label Jun 6, 2025

trygvrad mentioned this pull request Jun 15, 2025

Abstract base class for Normalize #30178

Merged

Update colors.pyi

2d9d00c

timhoffm reviewed Aug 1, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

trygvrad added 2 commits August 5, 2025 17:00

change to handling of bad norm names in MultiNorm

68c5527

Update colors.py

aa99db3

QuLogic reviewed Aug 7, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.pyi Outdated Show resolved Hide resolved

Apply suggestions from code review

f61c06b

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

trygvrad force-pushed the multivariate-plot-prapare branch from ff2eb20 to f61c06b Compare August 7, 2025 21:25

change minimum length of multiNorm to 1.

c0a0d6d

QuLogic reviewed Aug 16, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/tests/test_colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

QuLogic reviewed Aug 16, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

Apply suggestions from code review

3267fe9

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

trygvrad force-pushed the multivariate-plot-prapare branch from 486a58f to 3267fe9 Compare August 16, 2025 20:42

QuLogic added this to the v3.11.0 milestone Aug 19, 2025

QuLogic reviewed Aug 20, 2025

View reviewed changes

lib/matplotlib/colors.py Outdated Show resolved Hide resolved

lib/matplotlib/colors.pyi Outdated Show resolved Hide resolved

Apply suggestions from @QuLogic

a9aac0d

QuLogic approved these changes Aug 20, 2025

View reviewed changes

QuLogic merged commit 3a8ad1d into matplotlib:main Aug 20, 2025
38 of 40 checks passed

github-project-automation bot moved this from In Progress to Done in Bivariate and Multivariate Colormapping Aug 20, 2025

Migelo mentioned this pull request Aug 21, 2025

add path_effects example to README trygvrad/colorstamps#3

Merged

This was referenced Aug 25, 2025

removed test_image_cursor_formatting() #30465

Merged

No need to sanitize extrema in Colorizer.set_clim #30470

Merged

trygvrad mentioned this pull request Sep 3, 2025

Update Colorizer/ColorizingArtist to work with MultiNorm #30511

Merged

1 task

Uh oh!

Conversation

trygvrad commented Apr 6, 2025

PR summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anntzer left a comment

Choose a reason for hiding this comment

Uh oh!

trygvrad commented May 4, 2025

Uh oh!

timhoffm commented May 5, 2025

Uh oh!

trygvrad commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trygvrad commented Jun 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trygvrad commented Jun 6, 2025

Uh oh!

trygvrad commented Aug 1, 2025

Uh oh!

Uh oh!

anntzer commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trygvrad commented Aug 14, 2025

Uh oh!

QuLogic commented Aug 15, 2025

Uh oh!

trygvrad commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!