Fix passing singleton sequence-type styles to hist#29719
Fix passing singleton sequence-type styles to hist#29719story645 merged 1 commit intomatplotlib:mainfrom
Conversation
|
OK so we can't just use |
Is this related to #28475? |
Yes exactly. The array has zero size, so you get a |
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I have been pondering for a time whether we should have an internal helper to loop over possibly list-type properties. This should take care of all the technical details like single value vs. list of values, properly handling sequence-like single values, optionally length checks (we currently don't have a clear policy whether we request the same size, or whether we are permissive and continuously cycle as long as needed, which may be handy in some cases but could hide a bug in others).
…719-on-v3.10.x Backport PR #29719 on branch v3.10.x (Fix passing singleton sequence-type styles to hist)
3 participants
PR summary
Fixes #29717. Use of
np.atleast_1dhere is not appropriate for style properties expressed as tuples or array-likes. For colours we can just useto_rgba_array. For linestyles I factored out the logic used to set one or more linestyles inCollection.We are already using
to_rgba_arrayif colors is passed:matplotlib/lib/matplotlib/axes/_axes.py
Lines 6997 to 6998 in 70d0bf7
PR checklist