X Tutup
Skip to content

DOC / BUG: Fix savefig to GIF format with .gif suffix#29372

Merged
QuLogic merged 3 commits intomatplotlib:mainfrom
lpsinger:savefig-gif
Jan 16, 2025
Merged

DOC / BUG: Fix savefig to GIF format with .gif suffix#29372
QuLogic merged 3 commits intomatplotlib:mainfrom
lpsinger:savefig-gif

Conversation

@lpsinger
Copy link
Copy Markdown
Contributor

@lpsinger lpsinger commented Dec 22, 2024

PR summary

According to https://matplotlib.org/stable/users/explain/figure/figure_intro.html#saving-figures:

Many types of output are supported, including raster formats like
PNG, GIF, JPEG, TIFF and vector formats like PDF, EPS, and SVG.

However, GIF support was broken by #6178. Restore GIF support.

PR checklist

According to
https://matplotlib.org/stable/users/explain/figure/figure_intro.html#saving-figures:

> Many types of output are supported, including raster formats like
> PNG, GIF, JPEG, TIFF and vector formats like PDF, EPS, and SVG.

However, GIF support was broken by matplotlib#6178. Restore GIF support.
@tacaswell tacaswell added this to the v3.11.0 milestone Dec 23, 2024
@tacaswell
Copy link
Copy Markdown
Member

Test failure looks real, but I think it is due to our minimum verison of pillow being per 9.0 when the improved transparency + gif support was added.

I'm going to open a PR to bump that (seems better to do the API change to bump the minimum version on its own).

Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
@tacaswell tacaswell closed this Dec 23, 2024
@tacaswell tacaswell reopened this Dec 23, 2024
@tacaswell
Copy link
Copy Markdown
Member

"power cycled" to generate a new (synthetic) merge `ommit against main.

@QuLogic QuLogic merged commit 3b54c6a into matplotlib:main Jan 16, 2025
@lpsinger lpsinger deleted the savefig-gif branch January 16, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup