Fixed imsave() saving incorrect color map #29203
Closed
gpxxlt wants to merge 6 commits intomatplotlib:mainfrom
Closed
Fixed imsave() saving incorrect color map #29203gpxxlt wants to merge 6 commits intomatplotlib:mainfrom
gpxxlt wants to merge 6 commits intomatplotlib:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Goal
This pull request is made to address issue #29183. It closes #29183.
Implementation
This pull request added an
ifbranch within the functionimsave()in the pathlib/matplotlib/image.py. It is added to handle the case addressed in issue #29183 where inputarris a vanilla python list.Testing
One test case is added to
lib/matplotlib/tests/test_image.pyso there is a round trip fromimread()toimsave(). Test input is designed to be a vanilla python list so that the newly added branch is covered in test suite.PR checklist