Mark triangulation classes as final#27894
Merged
dstansby merged 1 commit intomatplotlib:mainfrom Mar 10, 2024
Merged
Conversation
Prior to their conversion to pybind11 classes in matplotlib#24522, these types had `tp_flags = Py_TPFLAGS_DEFAULT`, meaning they did not have the `Py_TPFLAGS_BASETYPE` flag and could not be subtyped. As these are internal classes, I don't believe this was intentionally changed, so restore that flag. Additionally, since we require C++17 now, mark the C++ classes themselves as `final`. I believe this really only makes a difference if we have `virtual` methods (which we don't here), but that doesn't mean the compiler can't infer some other optimizations with this information.
timhoffm
approved these changes
Mar 9, 2024
dstansby
approved these changes
Mar 10, 2024
Member
|
I am not in favour of these changes. None of the C++ classes here are polymorphic, there are no virtual functions, there are no vtables, all function calls are direct function calls and there are no optimisations available. It looks like unnecessary code churn and an increase in code complexity for no tangible benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Prior to their conversion to pybind11 classes in #24522, these types had
tp_flags = Py_TPFLAGS_DEFAULT, meaning they did not have thePy_TPFLAGS_BASETYPEflag and could not be subtyped. As these are internal classes, I don't believe this was intentionally changed, so restore that flag.Additionally, since we require C++17 now, mark the C++ classes themselves as
final. I believe this really only makes a difference if we havevirtualmethods (which we don't here), but that doesn't mean the compiler can't infer some other optimizations with this information.PR checklist