Work around pyparsing diagnostic warnings#27685
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Mar 13, 2024
Merged
Conversation
tacaswell
approved these changes
Mar 13, 2024
QuLogic
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25204
PR summary
This feels a bit more "workaround" than I'd really like, but it seems to work.
leads me to believe that we are relying on something that could change
python -Wdefault, but not enabled in our test suiteForwardGroup,+ Empty(), etc)The
_fontconfig_pattern.pyis a compatibility change adding aGroupwhich was suggested by a similar warning.PR checklist