Adding test for axes.streamplot using datetime#27489
Adding test for axes.streamplot using datetime#27489jhimanish wants to merge 1 commit intomatplotlib:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
Thank you for finding this.
It is actually the the goal of doing this exercise to find the places where we think we should support unitful behavior but do not.
I have opened #27500 to track the underlying problem.
I will block merging this until the underlying problems are addressed.
melissawm
added
the
status: autoclose candidate
melissawm
moved this from Needs decision
to Waiting for author
in First Time Contributors
|
⏰ This pull request might be automatically closed in two weeks from now. Thank you for your contribution to Matplotlib and for the effort you have put into this PR. This pull request does not yet meet the quality and clarity standards needed for an effective review. Project maintainers have limited time for code reviews, and our goal is to prioritize well-prepared contributions to keep Matplotlib maintainable. Matplotlib maintainers cannot provide one-to-one guidance on this PR. However, if you ask focused, well-researched questions, a community member may be willing to help. 💬 To increase the chance of a productive review:
As the author, you are responsible for driving this PR, which entails doing necessary background research as well as presenting its context and your thought process. If you are a new contributor, or do not know how to fulfill these requirements, we recommend that you familiarize yourself with Matplotlib's development conventions or engage with the community via our Discourse or one of our meetings before submitting code. If you substantially improve this PR within two weeks, leave a comment and a team member may remove the |
4 participants
PR summary
I've created a test for Axes.streamplot in test_datetime.py as requested in #26864
I tried using the normal datetime.datetime data type and passing that into np.meshgrid. However, it looks like np.meshgrid doesn't accept the datetime type and only accepts numerical arrays. I tried doing some research and looking into np.meshgrid further but could not find any way to pass in an array of datetime values. Therefore, I had to convert the datetime values into numerical values using date2num. This allows it to be passed into np.meshgrid to create the X and Y arrays which are then passed into the streamplot function.
Note: I am new to working with matplotlib and also new to open-source contributions so I would really appreciate your support and advice on this PR.
The outputted graph is as follows:
PR checklist