Fixes : Add setter/getter methods for all keyword parameters to Figure.__init__ #24617#27257
Fixes : Add setter/getter methods for all keyword parameters to Figure.__init__ #24617#27257Lambxx wants to merge 8 commits intomatplotlib:mainfrom
Conversation
layout needs added
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for taking this on! Since you're building on a previous committees work, can you please add them as a coauthor https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
Thanks for letting me know, ill take a look and do that |
Testing added Co-Authored by : Co-authored-by: @stanleyjs
GetSubPlot bars author added : Co-Authored by : Co-authored-by: @stanleyjs
|
Co author : @stanleyjs added to commits |
|
Thanks for pointing that out ill look through and see if i can fix some of them |
deleted cbar in error added back
|
Im looking through the errors and trying to fix, but bit confused about the meaning of this one, any pointers appreciated Stub: in file lib/matplotlib/figure.pyi |
Updated with original test from matplotlib#21549 written by @stanleyjs Co-Authored-By: Jay Stanley <stanleyjs@users.noreply.github.com>
|
Tests should be added to https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_figure.py and not put in a new file -> I think that's why coverage thinks nothing is tested. And that error is I think cause you need to add the new setter/getter methods to https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/figure.pyi see https://matplotlib.org/devdocs/devel/contribute.html#type-hints |
|
We discussed issue #24617 in the weekly meeting yesterday, and the general opinion is that this issue needs refinement before it's actually actionable. For this reason, I will close all related open issues for now. This does not mean you can't open another PR in the future or that your solution is necessarily innapropriate, but this will help us focus our efforts. Thank you for your contribution and hope to see you around! |
github-project-automation
bot
moved this from Waiting for author
to Done
in First Time Contributors
3 participants
PR summary
This fixes Add setter/getter methods for all keyword parameters to Figure.init #24617
#24617
. It adds getters and setters for :
SubplotBars
Figsize
Layout .
It cherry picks code from #21549
as well as adding missing get/set for figsize
-->