MNT: Numpy 2.0 removals from ndarray class#26762
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Sep 14, 2023
Merged
Conversation
xref numpy/numpy#24682 Only a handful of lines, and _mostly_ in tests/relatively unused utility functions like rgb_to_hsv, but still something that should be addressed.
QuLogic
approved these changes
Sep 14, 2023
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
I'm not sure if it matters too much, but the upstream PR does do the view before byteswap.
Member
Author
|
I'm pretty sure those are equivalent; byteswap will incur a copy (unless inplace=True) and view is just a view, but whether the copy comes before or after the view doesn't really matter. |
timhoffm
approved these changes
Sep 14, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
xref numpy/numpy#24682
Only a handful of lines, and mostly in tests/relatively unused utility functions like
rgb_to_hsv, but still something that should be addressed.PR checklist