FIX: array labelcolor for Tick#26598
Conversation
| def test_tick_labelcolor_array(): | ||
| # Smoke test that we can instantiate a Tick with labelcolor as array. | ||
| ax = plt.axes() | ||
| XTick(ax, 0, labelcolor=np.array([1, 0, 0, 1])) |
There was a problem hiding this comment.
is there a test somewhere that this actually works?
There was a problem hiding this comment.
I’m sorry I don’t understand the question.
There was a problem hiding this comment.
Sorry, you've got this setup as a smoke test so I was wondering if somewhere in the code there's a test that passing an array to xtick color colors the tick the color of the array.
There was a problem hiding this comment.
One can add that check via tick.label1.get_color() (and also for label2; and if you want to be even more precise check that tick1line, tick2line and gridline do not get that color).
There was a problem hiding this comment.
Sorry, I did intend to respond to this but have not been well for a few days. It looks like I’m too late now but there is this test that sets a labelcolor with a string and then checks it via the getter:
https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_axes.py#L6778-L6788
Is that enough or is there a concern that using an array could break things further along the process than the instantiation?
There was a problem hiding this comment.
Latter but also it's not a blocker and we can always add later if there's a bug that shows we should have added it ;)
Hope you're feeling better!
…598-on-v3.7.x Backport PR #26598 on branch v3.7.x (FIX: array labelcolor for Tick)
…598-on-v3.8.x Backport PR #26598 on branch v3.8.x (FIX: array labelcolor for Tick)
…t-of-pr-26598-on-v3.7.x Backport PR matplotlib#26598 on branch v3.7.x (FIX: array labelcolor for Tick)
4 participants
PR summary
Fixes #26588 following @anntzer's suggestion at #26588 (comment). The example code from #26588 (comment) now produces
Is there a better place to put the test? I wasn't expecting to create a new module...
PR checklist