X Tutup
Skip to content

Small axislines.Axes cleanups.#25774

Merged
oscargus merged 1 commit intomatplotlib:mainfrom
anntzer:al
Apr 27, 2023
Merged

Small axislines.Axes cleanups.#25774
oscargus merged 1 commit intomatplotlib:mainfrom
anntzer:al

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 26, 2023

  • Deprecate the "callable axes" API, which is not present anywhere else nor documented nor tested.
  • No need to set the transform on the GridlinesCollection; _set_artist_props takes care of that.

PR Summary

PR Checklist

Linked Issue

  • Added "closes #0000" in the PR description to link it to the original issue.

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@@ -0,0 +1,4 @@
Callable axisartist Axes
~~~~~~~~~~~~~~~~~~~~~~~~
Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Calling an axisartit Axes to mean `.Axes.axis` is deprecated; explicitly call
Calling an axisartist Axes to mean `.Axes.axis` is deprecated; explicitly call

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, fixed

- Deprecate the "callable axes" API, which is not present anywhere else
  nor documented nor tested.
- No need to set the transform on the GridlinesCollection;
  _set_artist_props takes care of that.
@oscargus oscargus merged commit b3c38d7 into matplotlib:main Apr 27, 2023
@anntzer anntzer deleted the al branch April 27, 2023 10:53
ksunden added a commit to ksunden/matplotlib that referenced this pull request Apr 27, 2023
eslothower pushed a commit to eslothower/matplotlib that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup