CI: skip appveyor for doc only change#25383
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Mar 6, 2023
Merged
Conversation
greglucas
approved these changes
Mar 4, 2023
Contributor
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
Looks good, but oddly enough this worked while the GitHub Actions tests still ran! So the GitHub Actions version might be incorrect...
.appveyor.yml
Outdated
Comment on lines
+16
to
+18
| - 'galleries/examples/**' | ||
| - 'galleries/plot_types/**' | ||
| - 'galleries/tutorials/**' |
Contributor
There was a problem hiding this comment.
Suggested change
| - 'galleries/examples/**' | |
| - 'galleries/plot_types/**' | |
| - 'galleries/tutorials/**' | |
| - 'galleries/**' |
I think we can just skip the entire galleries directory.
Member
Author
Yeah, I've been digging around the docs for that, as I've noticed it before. From what I can tell, |
ksunden
approved these changes
Mar 6, 2023
Member
|
@rcomer maybe self merge if you are done? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Consistent with recent changes for CI on other platforms (#25145, #25261), this change should mean the Appveyor CI is skipped if the only changes are under
docor in thegalleries, or if[ci doc]is in the commit message. Following the guidance here:https://www.appveyor.com/docs/how-to/filtering-commits/
I added
[ci doc]to the current commit, to test it works.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst