Simplify "artist reference" example.#25018
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jan 20, 2023
Merged
Conversation
Member
|
Perhaps link to the patch collection example to keep some of the cross linking? We don't do a good enough job of cross linking things so it seems a shame to drop an opportunity here. |
In particular, add each artist directly to its own axes, instead of shifting each of them by some offset and grouping all of them together in a PatchCollection. Note that this makes the example no longer showcase the use of PatchCollection, but at least based on the docstring that was not the intent of the example anyways, and PatchCollection is showcased elsewhere (in the patch_collection.py example, in particular).
Contributor
Author
|
sure. |
jklymak
reviewed
Jan 18, 2023
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Thanks - ping for a merge if I forget - I'll double check that it all looks OK.
QuLogic
approved these changes
Jan 20, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 20, 2023
rcomer
added a commit
that referenced
this pull request
Jan 20, 2023
…018-on-v3.7.x Backport PR #25018 on branch v3.7.x (Simplify "artist reference" example.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, add each artist directly to its own axes, instead of shifting each of them by some offset and grouping all of them together in a PatchCollection. Note that this makes the example no longer showcase the use of PatchCollection, but at least based on the docstring that was not the intent of the example anyways, and PatchCollection is showcased elsewhere (in the patch_collection.py example, in particular).
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst