Conversation
|
You might want to squash some of these commits. |
|
Sorry I just falsely assumed github would create a patch upon pull
|
matplotlibrc.template
Outdated
There was a problem hiding this comment.
silly formatting thing, can you put the sentence about the incompatibility on a new line?
There was a problem hiding this comment.
done. let me know if that's not what you meant
|
@tacaswell, I think it needs to be rebased interactively to eliminate the merge commit. I would not merge it as-is. |
|
I have no issues with the content -- but as @efiring said, we'll need to get the merge commit out. |
|
Probably easiest if I just open a separate pull request on a new branch. Sorry for the mess. |
|
Moved all changes to a new branch and sent Pull Request #2615 |
4 participants
First commit changes the order of arguments in the call to
ffmpeg. Now output options go with the output file instead of the input file. This avoids an issue withffmpeg 2.xrejecting the call.Second commit fixes a bug where
xrange()was assumed (incorrectly) to be a generator. It is in fact some sort of lazy list, so it does not have the__next__()method generators have.The bug manifested itself when callingFuncAnimate()with a constant number of frames, like inexamples/animation/basic_example.py.Third commit adds a note in the
INSTALLdocument about the incompatibility of thetightsetting forbboxwith generating movies using pipe writers, likeffmpeg.