X Tutup
Skip to content

Show that fill_between and span_where provide similar functionalities.#24843

Merged
rcomer merged 1 commit intomatplotlib:mainfrom
anntzer:fbsw
Dec 31, 2022
Merged

Show that fill_between and span_where provide similar functionalities.#24843
rcomer merged 1 commit intomatplotlib:mainfrom
anntzer:fbsw

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Dec 29, 2022

PR Summary

In preparation for a possible deprecation of BrokenBarHCollection (#24827), which may be a good idea.
Using axes methods is usually simpler for end users, anyways.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

rcomer
rcomer reviewed Dec 31, 2022
View reviewed changes
rcomer
rcomer approved these changes Dec 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite improvement. I just have one trivial suggestion that you are welcome to ignore if you wish.

@rcomer rcomer added this to the v3.6-doc milestone Dec 31, 2022
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Dec 31, 2022

sure, done.

@rcomer rcomer merged commit 087ca0c into matplotlib:main Dec 31, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 31, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 31, 2022
@rcomer @meeseeksmachine
Backport PR matplotlib#24843: Show that fill_between and span_where p…
19fe70a 
…rovide similar functionalities.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 31, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 31, 2022
@rcomer @meeseeksmachine
Backport PR matplotlib#24843: Show that fill_between and span_where p…
5066a90 
…rovide similar functionalities.
ksunden added a commit that referenced this pull request Jan 1, 2023
@ksunden
Merge pull request #24852 from meeseeksmachine/auto-backport-of-pr-24…
0b2bd04 
…843-on-v3.6.x

Backport PR #24843 on branch v3.6.x (Show that fill_between and span_where provide similar functionalities.)
ksunden added a commit that referenced this pull request Jan 1, 2023
@ksunden
Merge pull request #24853 from meeseeksmachine/auto-backport-of-pr-24…
fc0ce43 
…843-on-v3.6.2-doc

Backport PR #24843 on branch v3.6.2-doc (Show that fill_between and span_where provide similar functionalities.)
@anntzer anntzer deleted the fbsw branch January 1, 2023 18:07
@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 25, 2023

@meeseeksdev backport to v3.7.x

@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Jan 25, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 087ca0c615f697dc857277b0fb87657c13ee0eed
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24843: Show that fill_between and span_where provide similar functionalities.'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-24843-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #24843 on branch v3.7.x (Show that fill_between and span_where provide similar functionalities.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 25, 2023

OK, will do it as part of the merge myself.

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 25, 2023

Actually, I misunderstood the conflict; this conflicts because it was deprecated in 3.7; there's no need to backport this PR.

@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
HarshitZom added a commit to HarshitZom/matplotlib that referenced this pull request Nov 23, 2025
@HarshitZom
Fix HPacker 'align' option reversing 'top' and 'bottom'
6e55310 
Correct the mapping of 'top' and 'bottom' in HPacker's alignment logic so 'align="top"' and 'align="bottom"' now match expected visual behavior.

Add tests to ensure HPacker and VPacker alignment options work as intended.

Fixes matplotlib#24843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcomer rcomer rcomer approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.6-doc

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @QuLogic @rcomer
X Tutup