Merged
Conversation
tacaswell
approved these changes
Dec 19, 2022
Member
|
But we've always needed a C++ compiler; I don't mind installing it, I guess, but why is that changed due to #24522? |
ksunden
requested changes
Dec 20, 2022
We need pybind11 and a C++ compiler because of matplotlib#24522
timhoffm
force-pushed
the
update-environment
branch
from
02fd48e to
f33b4d4
Compare
Member
Author
|
I've removed the C++ compiler again. Not sure why I started to need it. My dev environment started to complain, but I'm not sure whether it was actually due to #24522. It was more of a guess because that was the thing that recently changed. |
ksunden
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need pybind11 and a C++ compiler because of #24522