Don't manually invalidate cached lines in _update_transScale.#24654
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Dec 7, 2022
Merged
Don't manually invalidate cached lines in _update_transScale.#24654ksunden merged 1 commit intomatplotlib:mainfrom
ksunden merged 1 commit intomatplotlib:mainfrom
Conversation
Resetting transScale just above will invalidate any nodes that depend on it as well. (The manual line invalidation came in in ff3c65f to "fix log/linear toggle", but that toggle clearly works fine even with this removal; I assume that transform invalidation became better since then.)
oscargus
approved these changes
Dec 7, 2022
ksunden
approved these changes
Dec 7, 2022
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
rcomer
pushed a commit
to rcomer/matplotlib
that referenced
this pull request
Dec 10, 2022
…in _update_transScale Manual backport required due to simple conflict caused by the first removed line being different in main and v3.6.x, having previously been modified at matplotlib#24634.
6 tasks
oscargus
added a commit
that referenced
this pull request
Dec 10, 2022
Backport PR #24654: Don't manually invalidate cached lines in _update_transScale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetting transScale just above will invalidate any nodes that depend on it as well. (The manual line invalidation came in in ff3c65f to "fix log/linear toggle", but that toggle clearly works fine even with this removal; I assume that transform invalidation became better since then.)
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst