DOC: improved the doc for layout_engine.py#24548
Merged
story645 merged 2 commits intomatplotlib:mainfrom Nov 26, 2022
Merged
Conversation
jklymak
approved these changes
Nov 26, 2022
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Thanks for putting this in. Though maybe I shouldn't be the final review...
story645
approved these changes
Nov 26, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 26, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 26, 2022
Member
|
Congrats on your first PR 🥳 & thanks for putting in this change! We hope to see you again 😁 |
Contributor
Author
Thanks for your kind reply, I also wish to contribute to matplotlib frequently |
timhoffm
added a commit
that referenced
this pull request
Nov 27, 2022
…548-on-v3.6.x Backport PR #24548 on branch v3.6.x (DOC: improved the doc for layout_engine.py)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #24518
changed the doc as specified in the issue
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst