Fix potential issue in contour#24514
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Nov 21, 2022
Merged
Conversation
ksunden
approved these changes
Nov 21, 2022
timhoffm
approved these changes
Nov 21, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 21, 2022
QuLogic
added a commit
that referenced
this pull request
Nov 22, 2022
…514-on-v3.6.x Backport PR #24514 on branch v3.6.x (Fix potential issue in contour)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
It may be that imin is never assigned. All other variables that are in the same if-clause have default values, so an option is to remove all those if we are sure that they will always be assigned a value. But probably safer to provide a default value for imin.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst