Fix floating-point drift in oscilloscope example#24481
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Nov 17, 2022
Merged
Fix floating-point drift in oscilloscope example#24481tacaswell merged 1 commit intomatplotlib:mainfrom
tacaswell merged 1 commit intomatplotlib:mainfrom
Conversation
oscargus
approved these changes
Nov 17, 2022
Member
oscargus
left a comment
oscargus
left a comment
There was a problem hiding this comment.
Looks good!
Not merging as I thought this should go in 3.6-doc? But feel free to self merge as I trust your decision. (I thought I had finally understood the backport aspects...)
"Documentation changes (all .rst files and examples) are milestoned v3.N-doc."
Member
|
(I guess that there can still be some drift in particular cases, but this is for sure better than the previous version and it is also good that the default setting does not drift.) |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 17, 2022
oscargus
added a commit
that referenced
this pull request
Nov 17, 2022
…481-on-v3.6.x Backport PR #24481 on branch v3.6.x (Fix floating-point drift in oscilloscope example)
Member
Author
|
You're right it can go to doc as well. meeseeksdev backport to v3.6.x-doc |
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
Member
Author
|
Oops... meeseeksdev backport to v3.6.2-doc |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 18, 2022
ksunden
added a commit
that referenced
this pull request
Nov 18, 2022
…481-on-v3.6.2-doc Backport PR #24481 on branch v3.6.2-doc (Fix floating-point drift in oscilloscope example)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I left this running to about 3500s and it had not drifted out of the 2s interval.
Fixes #24476
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst