[ENH] hatch keyword for pie + some pie documentation#24470
Merged
jklymak merged 1 commit intomatplotlib:mainfrom Jan 11, 2023
Merged
[ENH] hatch keyword for pie + some pie documentation#24470jklymak merged 1 commit intomatplotlib:mainfrom
jklymak merged 1 commit intomatplotlib:mainfrom
Conversation
oscargus
reviewed
Nov 16, 2022
Member
|
I think this makes sense! |
oscargus
reviewed
Dec 21, 2022
6c6218e to
60f9af8
Compare
a74fa53 to
7b7c8fa
Compare
timhoffm
reviewed
Dec 22, 2022
jklymak
approved these changes
Jan 5, 2023
oscargus
reviewed
Jan 6, 2023
oscargus
reviewed
Jan 6, 2023
625d2e6 to
520480b
Compare
Member
Author
|
I don't think the failing tests are connected to this PR 😟 |
QuLogic
approved these changes
Jan 10, 2023
Member
|
Test failures are unrelated. |
Member
Author
|
I wrote alt text for the what's new entry here but should I just put that as a follow up so this doesn't go through another round of reviews? |
Member
|
You can add it here if you want to update and get #24921 in to fix CI. |
dstansby
approved these changes
Jan 10, 2023
Member
dstansby
left a comment
There was a problem hiding this comment.
Looks good - just one question, which is either a quick fix or I'm missing something. Either way happy for this to be merged once it's been considered!
oscargus
reviewed
Jan 10, 2023
reworded pctdistance and labeldistance b/c of matplotlib#24789 Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> Co-authored-by: sledziu32 <sledziu32@gmail.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
jklymak
approved these changes
Jan 11, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 11, 2023
QuLogic
added a commit
that referenced
this pull request
Jan 11, 2023
…470-on-v3.7.x Backport PR #24470 on branch v3.7.x ([ENH] hatch keyword for pie + some pie documentation)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added the ability to pass in a list of wedgeproperty dicts, one for each wedge of the pie. Follow on to #2923, would probably address #3134 , inspired by twitter convoYes, I know it can be achieved via loop - see the fig comparison test in this PR - but we were already looping over the wedges inside the function to set all the other properties so the major addition is testing if the input is a dict or list of dicts. <- this could possibly be factored into a cbook function, my guess being 'if thing not list wrap in repeat' is not uncommon in the codebase.
Current Iteration
which would produce roughly
I'll put in a what's new and example if there's consensus on this going in.
PR Checklist
Tests and Styling
pytestpasses).Documentation
Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst