MNT: Update pre-commit hooks#24196
Conversation
matthewfeickert
left a comment
matthewfeickert
left a comment
There was a problem hiding this comment.
Summary of why each of these changes is applied:
| cannotation | ||
| coo | ||
| curvelinear | ||
| dedented |
There was a problem hiding this comment.
Use in
matplotlib/lib/matplotlib/axes/_base.py
Line 48 in 23730b4
is reasonable so adding to ignore.
| coo | ||
| curvelinear | ||
| dedented | ||
| falsy |
There was a problem hiding this comment.
Falsy is how Python spells it, so adding.
| dedented | ||
| falsy | ||
| flate | ||
| hax |
There was a problem hiding this comment.
Use in
for "horizontal axis" is reasonable, so added. However, if it would be preferable to make the example variables more explicit and verbose I can edit them instead.
| flate | ||
| hax | ||
| hist | ||
| inh |
There was a problem hiding this comment.
Use in
matplotlib/lib/matplotlib/transforms.py
Line 2562 in 23730b4
for "invalid height" is reasonable, so added.
| nd | ||
| oly | ||
| sur | ||
| resizeable |
There was a problem hiding this comment.
Use in
matplotlib/doc/devel/MEP/MEP09.rst
Line 9 in 23730b4
is a valid spelling, and so adding to ignore file.
sur is removed as added to the codespell dictionary in v2.2.0. c.f. codespell-project/codespell#2300
|
As this is a follow up to PR #22809, then tagging @oscargus, @greglucas, @jklymak, and @QuLogic for possible reviewers. |
|
To me it seems like just closing #24086 when this is merged would be the way to go. |
|
That's totally fine! The pre-commit.ci bot doesn't care at all. I'll just be better in the future about checking for those PRs before opening another one. I've updated the PR body to close PR #24086 automatically now. |
matthewfeickert
force-pushed
the
mnt/update-pre-commit-hooks
branch
from
bb6702b to
7e2b17c
Compare
* github.com/pycqa/flake8: v4.0.1 → v5.0.4 * github.com/codespell-project/codespell: v2.1.0 → v2.2.2
* Use 'name' to additionally avoid codespell failure.
Ignore instances of: * 'dedented', 'resizeable' * 'falsy' for Falsy in Python * 'hax' for horizontal axis * 'inh' for invalid height Remove ignore of 'sur' as it is in codespell's dictionary as of v2.2.0. - c.f. https://github.com/codespell-project/codespell/releases/tag/v2.2.0
matthewfeickert
force-pushed
the
mnt/update-pre-commit-hooks
branch
from
7e2b17c to
b41e130
Compare
3 participants
PR Summary
Update the
codespellpre-commit hook, and while doing so also update theflake8pre-commit hook.Note that this PR would eventually be done by the quarterly update, and so feel free to close if you'd prefer to wait for that, but this takes care of additional updates now.
Follow up PR to PR #22809.
Closes #24086
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).