TST: convert nose-style tests#24173
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Oct 15, 2022
Merged
Conversation
oscargus
approved these changes
Oct 15, 2022
timhoffm
approved these changes
Oct 15, 2022
Member
|
@meeseeksdev backport to v3.6.x Not sure whether backporting is need, but better be on the safe side if pytest is releasing before matplotlib v3.7. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 15, 2022
oscargus
added a commit
that referenced
this pull request
Oct 15, 2022
…173-on-v3.6.x Backport PR #24173 on branch v3.6.x (TST: convert nose-style tests)
Member
Author
Member
|
Thank you @rcomer ! I'm glad the fix here was straight forward. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Dec 8, 2022
https://build.opensuse.org/request/show/1041050 by user dgarcia + dimstar_suse - Add fix-tests-pytest72.patch to fix tests failing with pytest 7.2 gh#matplotlib/matplotlib#24173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A minimal change to resolve #24148. Replaced Nose's
setupwith pytest'ssetup_method. I note that there is already an instance ofsetup_methodwithin test_transforms.py. I installedpytestwithpip install git+https://github.com/pytest-dev/pytest.git@mainand verified that
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).